Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FIPS with cmake #79

Merged
merged 5 commits into from
Mar 30, 2025
Merged

Replace FIPS with cmake #79

merged 5 commits into from
Mar 30, 2025

Conversation

vikhik
Copy link
Contributor

@vikhik vikhik commented Mar 30, 2025

This is a mostly working overhaul to replace FIPS with cmake.

The only part missing is testing with linux and macOS.
Seeing as I have limited access to those devices, I'd appreciate if the maintainer can support me in this :)

ref: #78 (comment)

vikhik added 4 commits March 30, 2025 14:15
@vikhik
feat(cmake): Replace FIPS with CMake
e8c08a9 
* Set up new vscode envs that are more portable
* Move samples into subfolders
* Initial cmake migration using CPM for package management
* Unit tests pass
* Samples folder fixed in subsequent commits
@vikhik
fix(cmake): Basic sample works
e05a3f9
@vikhik
fix(cmake): ImGui sample works
029b38c
@vikhik
fix: Fixes for compilation and running on linux (under WSL)
b8df878 
Note: imgui_host runs but shows nothing but a black screen, further debugging is required.
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@fungos
Copy link
Owner

fungos commented Mar 30, 2025 •
edited
Loading

I did a quick test here and everything seems good. Unfortunately I don't have access to a Mac anymore, but I believe that it should still be working. 🤞

Before pushing this, I have a few requests:

  1. There is a Changelog section in cr.h, please add a quick information about the build system change from fips to pure cmake. Also include the change from cr.h -> cr/cr.h
  2. There is also a Contributors section in cr.h, please append your information in the end of that section.
  3. You added the build instructions in the README.md, actually, you should add these instructions in the cr.h file. The README.md is a copy from cr.h, so they should always match.

With that I'll merge this PR.
Thanks a lot for contributing to cr.h!

@vikhik vikhik marked this pull request as ready for review March 30, 2025 15:11
@fungos fungos merged commit bb17fe7 into fungos:master Mar 30, 2025
3 checks passed
@vikhik vikhik deleted the feature/cmake branch April 2, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikhik @fungos