fix: CMBLensed handling monopole and dipole #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I've applied similar suggestions as appear in #214 to this pull request. The notebook has been moved to gist.github.com: https://gist.github.com/JamesAmato/239298918103212163dbb4f7c0acfe7c |
zonca
requested changes
Mar 20, 2025
JamesAmato
force-pushed
the
cmb_lensed_handle_l01
branch
from
d236cfc to
cd99bc2
Compare
|
thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in CMBLensed where having the monopole and dipole in CAMB's power spectra cause errors (Issue #212).
Includes a demonstration notebook at the top level to prevent issues with imports (intended for review).
Also includes a test for the
cmb_spectra.While the change does address L=0 and L=1 in
delensing_ells, it cannot be tested without addressing Issue #213. (Even if a test were included, it would only check for crashes -- I don't have a known-good result.)