Skip to content

Validate that users request more than 0 resources. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

joaander
Copy link
Member

@joaander joaander commented Apr 1, 2025

Description

Ensure that users request more than 0 resources.

Motivation and context

Row passes values that the user provides directly through to the scheduler. For example, when a user requests gpus_per_processes = 0, row will dutifully place #SBATCH --gpus-per-task=0 in the submission script. At the same time, row interprets gpus_per_process => Some(_) as a request for GPUs.

This change validates that the user workflow must request at least 1 process, GPU, and/or thread. It informs the user to omit the request to request no resources.

Resolves #86

How has this been tested?

Unit tests verify all new errors.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the Row Contributor Agreement.
  • My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
  • I have added a change log entry to doc/src/release-notes.md.

@joaander joaander marked this pull request as ready for review April 1, 2025 13:37
@joaander joaander merged commit f7056b9 into trunk Apr 3, 2025
17 checks passed
@joaander joaander deleted the error-zero-resources branch April 3, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"memory_per_cpu = '8G'" in cluster.partition does not populate the row submit --dry-run
1 participant