Validate that users request more than 0 resources. #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that users request more than 0 resources.
Motivation and context
Row passes values that the user provides directly through to the scheduler. For example, when a user requests
gpus_per_processes = 0
, row will dutifully place#SBATCH --gpus-per-task=0
in the submission script. At the same time, row interpretsgpus_per_process => Some(_)
as a request for GPUs.This change validates that the user workflow must request at least 1 process, GPU, and/or thread. It informs the user to omit the request to request no resources.
Resolves #86
How has this been tested?
Unit tests verify all new errors.
Checklist:
doc/src/contributors.md
) in the pull request source branch.doc/src/release-notes.md
.