[Strongly Typed Params] Typed params in context #406
Conversation
EwenQuim
force-pushed
the
typed-params-in-context
branch
from
f347536 to
b227d91
Compare
EwenQuim
force-pushed
the
typed-params-in-context
branch
from
b5eb80c to
ef177ea
Compare
|
Is this ready for review? |
|
Yes, it is only a first step as it does not implement the solution but it paves the way to support typed params in a backward-compatible way (except for testing with |
|
Got it. Will review soon. |
EwenQuim
changed the title
There was a problem hiding this comment.
I believe go work and all the go mods should probably be bumped on the commit titled Update go version to 1.24
| _ Context[any, any] = &netHttpContext[any, any]{} // Check that ContextWithBody implements Ctx. | ||
| _ ContextWithBody[any] = &netHttpContext[any, any]{} // Check that ContextWithBody implements Ctx. | ||
| _ ContextWithBody[string] = &netHttpContext[string, any]{} // Check that ContextWithBody implements Ctx. | ||
| _ ValidableCtx = &netHttpContext[any, any]{} // Check that ContextWithBody implements ValidableCtx. |
There was a problem hiding this comment.
I think there is a lot of copy pasta right here maybe with the comments? Probably should go above as well.
|
Hey, just discovered this project yesterday and I'm really impressed :). Forgive me if any of my comments/questions are uninformed. Will Param type support be an effective replacement for the route options All-in-all, I'm excited for this update; I think Param types fit the fuego philosophy much better than declarations via route options - leave it to the function signature to define params instead of the route registering logic (again, forgive me if I'm speaking out of turn). Also, I'm happy to help once I get more familiar with the codebase - if you'll have me. |
First step towards #356