Skip to content

feat: support prefixes for nested structs #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

bunyk
Copy link
Contributor

@bunyk bunyk commented Mar 6, 2024

A first draft implementation of #52, names of struct fields are considered now.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (f33e5de) to head (6b35484).

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #53      +/-   ##
===========================================
- Coverage   100.00%   90.57%   -9.43%     
===========================================
  Files            4        5       +1     
  Lines          227      276      +49     
===========================================
+ Hits           227      250      +23     
- Misses           0       22      +22     
- Partials         0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bunyk
Copy link
Contributor Author

bunyk commented Mar 12, 2024

I'll check the coverage later today

@tmzane
Copy link
Member

tmzane commented Mar 13, 2024

I'll check the coverage later today

Don't bother, looks like this is about changes in the coverage tool. I'll take a look later.

@tmzane
Copy link
Member

tmzane commented Mar 13, 2024

I'm going to push documentation updates and then we can merge it.

@tmzane tmzane self-requested a review March 13, 2024 13:50
@tmzane tmzane changed the title feat: stack nested field names (#52) feat: support prefixes for nested structs Mar 13, 2024
@tmzane tmzane merged commit 625998f into go-simpler:main Mar 13, 2024
5 of 6 checks passed
@tmzane
Copy link
Member

tmzane commented Mar 13, 2024

@bunyk thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants