Fix #5874: Use of designated initializers fails Windows build #5875
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designated initializers are a feature of C++20:
https://en.cppreference.com/w/cpp/language/aggregate_initialization. However, they appeared in
mediapipe/mediapipe/framework/output_stream_handler.cc
Lines 145 to 149 in ffe429d
The project uses C++17 and adapting it for C++20 would be non-trivial. The easiest fix is to avoid using aggregated initialization. It is fine while the order of members is preserved:
mediapipe/mediapipe/framework/output_stream_handler.h
Lines 53 to 59 in eecf8a5