Add Normalization and Action Clipping Wrappers #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd clipping wrappers
|
Hi @cruz-lucas , is the running statistic pattern in agents not sufficient for your use-case? Advantages can also be normalized in the PPO agent. ClipVecAction is not implemented, but it's usually simple enough to include the one-line jp.clip in the environment itself. What are your thoughts here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented new wrappers designed for on-device normalization and action clipping to address the CPU–GPU transfer issues when using gym’s normalization wrappers. This contribution addresses Issue #49. In particular, I added:
I also added sanity check tests to verify the correct behavior of these wrappers. Please let me know if this doesn't align with Brax's design philosophy.