Add API support for aborting promise calls #1478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampajano
force-pushed
the
1.export.abort.signal
branch
6 times, most recently
from
2c70fe2 to
f119074
Compare
sampajano
force-pushed
the
1.export.abort.signal
branch
from
f119074 to
579c564
Compare
sampajano
changed the title
sampajano
added a commit
to sampajano/grpc-web
that referenced
this pull request
Mar 8, 2025
sampajano
force-pushed
the
1.export.abort.signal
branch
from
579c564 to
f6e0f12
Compare
sampajano
added a commit
to sampajano/grpc-web
that referenced
this pull request
Mar 8, 2025
sampajano
force-pushed
the
1.export.abort.signal
branch
from
f6e0f12 to
587484f
Compare
sampajano
added a commit
to sampajano/grpc-web
that referenced
this pull request
Mar 8, 2025
sampajano
force-pushed
the
1.export.abort.signal
branch
from
587484f to
475758b
Compare
sampajano
added a commit
to sampajano/grpc-web
that referenced
this pull request
Mar 8, 2025
sampajano
force-pushed
the
1.export.abort.signal
branch
from
475758b to
dc8a5e3
Compare
sampajano
changed the title
sampajano
force-pushed
the
1.export.abort.signal
branch
from
10083ee to
cc46d6e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds API support for aborting promise calls in the gRPC-web client, aligning with internal codebase changes and updating dependency versions.
- Implement abort signal handling in thenableCall with both default and custom abort reasons
- Add tests to verify cancellation behavior and error propagation
- Remove CallOptions in favor of PromiseCallOptions and refactor getHostname export
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| javascript/net/grpc/web/grpcwebclientbase_test.js | Introduces tests for cancelled promise calls with and without a custom abort reason |
| javascript/net/grpc/web/grpcwebclientbase.js | Implements abort signal handling in thenableCall, adjusts unaryCall, and refactors interceptor chaining |
| javascript/net/grpc/web/abstractclientbase.js | Adds PromiseCallOptions and refactors the getHostname function export |
Files not reviewed (2)
- packages/grpc-web/docker/jsunit-test/Dockerfile: Language not supported
- packages/grpc-web/scripts/run_jsunit_tests.sh: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1096
CallOptionsin favor ofPromiseCallOptions(to align with internal codebase)112.0.5615.165for supporting abort with reason.TODO: