Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar design #1297

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Update sidebar design #1297

merged 3 commits into from
Mar 28, 2025

Conversation

ankormoreankor
Copy link
Collaborator

@ankormoreankor ankormoreankor commented Mar 25, 2025

New design for the collapsed state of the Sidebar component

  • Sidebar width in collapsed state is 62px; Collapse button moved to the sidebar body
  • Sidebar on mobile screen width opens with the old approach - a button at topbar
  • Sidebar legacy search bar is replaced with button in collapsed state
  • New search bar is collapsed to the size of square button when sidebar is collapsed state
  • New search bar is accessible from the keyboard now (can be activated with enter and space buttons)
  • More menu and Settings menu behave as modals: close on click outside
  • More, Settings and User Management menu items are accessible from keyboard now

image

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ankormoreankor ankormoreankor changed the base branch from main to update-color-tokens March 25, 2025 14:33
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 6a49380
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67e68a132fef390008c026e0
😎 Deploy Preview https://deploy-preview-1297--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 6a49380
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67e68a13fa4a210008d4f416
😎 Deploy Preview https://deploy-preview-1297--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiderr hiderr force-pushed the update-color-tokens branch 3 times, most recently from 9c8dac4 to 36fbacc Compare March 26, 2025 11:03
@ankormoreankor ankormoreankor force-pushed the update-sidebar-design branch 5 times, most recently from 78a7b28 to 97893e8 Compare March 26, 2025 11:42
@hiderr hiderr force-pushed the update-color-tokens branch 5 times, most recently from 6abe923 to 6f17bbe Compare March 27, 2025 07:53
@3em 3em force-pushed the update-color-tokens branch from 6f17bbe to ed8b1f7 Compare March 27, 2025 08:25
@ankormoreankor ankormoreankor force-pushed the update-sidebar-design branch 6 times, most recently from 791c429 to a8db08d Compare March 27, 2025 12:06
@3em 3em force-pushed the update-color-tokens branch from 2c0bfd0 to 1b9f4d3 Compare March 27, 2025 12:54
@3em 3em force-pushed the update-color-tokens branch from 1b9f4d3 to 9455319 Compare March 27, 2025 12:59
Base automatically changed from update-color-tokens to main March 27, 2025 13:11
@ankormoreankor ankormoreankor force-pushed the update-sidebar-design branch 3 times, most recently from a966a3f to ae6fa9c Compare March 28, 2025 11:29
@ankormoreankor ankormoreankor force-pushed the update-sidebar-design branch from ae6fa9c to 6a49380 Compare March 28, 2025 11:37
@3em 3em marked this pull request as ready for review March 28, 2025 12:18
@3em 3em requested a review from knagurski as a code owner March 28, 2025 12:18
@3em 3em merged commit df397ee into main Mar 28, 2025
16 checks passed
@3em 3em deleted the update-sidebar-design branch March 28, 2025 12:20
@sans-harness
Copy link
Contributor

@ankormoreankor this PR completely breaks the MFE since we haven't wrapper the AppMFE in sidebar-provider. Also, changes to layouts - SandboxLayout, PRLayout etc are breaking layouts across pages in the MFE. As a result I am reverting some of the changes in this PR. Changes to layouts are usually dangerous and need more oversight before merging.

cc: @abhinavrastogi-harness @vardanbansal-harness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants