[Sonic Frontiers] Two minor documentation changes to libraries #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperbx
requested changes
Nov 5, 2023
| /// <summary> | ||
| /// Is the Quick Cyloop gauge Active (false) or Charging (true). | ||
| /// </summary> | ||
| [FieldOffset(0xF1)] public bool QuickCyloopCharging; |
There was a problem hiding this comment.
Please confirm that this is a bool and not a short, as the constructor for this class suggests there's a 16-bit integer at offset 0xF0. This could be flags instead of a single boolean, but that could also be a compiler optimisation.
There was a problem hiding this comment.
0xF0 seems to also be flags - for instance bit 6 (*0xF0 & 0b0100_0000) seems to be 'isPhantomRushActive' so it could be a short
However I have no idea how to confirm this - I'm a complete outsider to this game's reverse engineering efforts.
hyperbx
force-pushed
the
main
branch
2 times, most recently
from
c4fae20 to
bf728de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor edits I thought I'd contribute.