Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update weight update process group #3211

Closed
wants to merge 1 commit into from

Conversation

ji-huazhong
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ji-huazhong ji-huazhong marked this pull request as draft April 2, 2025 13:12
@ji-huazhong ji-huazhong force-pushed the vllm-serve branch 6 times, most recently from bbf0752 to b0e18b4 Compare April 3, 2025 03:52
@jiangix-paper
Copy link

Hello, can i use it to do trl grpo in npu?
this is my question:
vllm-project/vllm-ascend#459

@ji-huazhong
Copy link
Contributor Author

@jiangix-paper
The current draft uses torch's collective communication interface, and some problems were found during testing, such as not supporting multi-NPU training. To solve this problem, I plan to refer to the existing implementation and introduce PyNcclCommunicator to support the creation of weight communication groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants