Hyprland toplevel mapping protocol #9775
Conversation
WhySoBad
force-pushed
the
hyprland-toplevel-mapping-protocol
branch
from
696f9f5 to
d85411b
Compare
|
Hi, Sorry for adding all labels, I accidentally rebased and pushed which triggered the bot. Anyways, I don't know how to fix the meson setup and Nix CI errors. I'd appreciate if someone could help me in this matter :) |
|
Can you rebase on main? Should fix the Nix CI. Don't know what's up with the Arch Meson CI. |
WhySoBad
force-pushed
the
hyprland-toplevel-mapping-protocol
branch
from
1ab6474 to
25a432c
Compare
|
I think the problem with the Nix build is that the hyprland-protocols revision is locked? However, I don't know anything about Nix so this is only a guess |
|
Yeah, seems like your fixup commit came later than my flake bump. |
Oh sorry, didn't notice you bumped the flake. I think you'll need to bump it again for hyprland-protocols 0.6.4 which includes the protocol in it's meson build. Thanks for the help :) |
| @@ -168,3 +168,14 @@ void CForeignToplevelProtocol::destroyHandle(CForeignToplevelHandle* handle) { | |||
| bool CForeignToplevelProtocol::windowValidForForeign(PHLWINDOW pWindow) { | |||
| return validMapped(pWindow) && !pWindow->isX11OverrideRedirect(); | |||
| } | |||
|
|
|||
| PHLWINDOW CForeignToplevelProtocol::windowFromHandleResource(wl_resource* res) { | |||
There was a problem hiding this comment.
this sucks, as it's slow and unintuitive. See e.g. CWLSurface::fromResource for how to do it right.
There was a problem hiding this comment.
alright, changed it. I also changed it for the wlr toplevel handle which already had this method implemented in the same way I did
src/protocols/ToplevelMapping.hpp
Outdated
| void destroyHandle(CHyprlandToplevelWindowMappingHandleV1* handle); | ||
|
|
||
| std::vector<UP<CToplevelMappingManager>> m_vManagers; | ||
| std::vector<SP<CHyprlandToplevelWindowMappingHandleV1>> m_vHandles; |
There was a problem hiding this comment.
don't rawdog resource types, please. Wrap it like you did for the manager
Describe your PR, what does it fix/add?
This pull requests adds the server implementation of the hyprland-toplevel-mapping-v1 protocol introduced in hyprwm/hyprland-protocols#16
Related:
close #9381
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Ready for merge