Use precomputed primaries conversion #9814
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2025
mhydock
reviewed
Apr 11, 2025
| // TODO make image descriptions immutable and always set an id | ||
|
|
||
| uint32_t SImageDescription::findId() const { | ||
| for (auto it = knownDescriptionIds.begin(); it != knownDescriptionIds.end(); ++it) { |
There was a problem hiding this comment.
nitpick: use for-each syntax, and maybe structured binding?
mhydock
reviewed
Apr 11, 2025
| mat[0][1], mat[1][1], mat[2][1], // | ||
| mat[0][2], mat[1][2], mat[2][2], // | ||
| }; | ||
| primariesConversionCache.insert(std::make_pair(cacheKey, glConvertMatrix)); |
There was a problem hiding this comment.
nitpick: is there a reason you're doing insert and std::make_pair instead of just primariesConversionCache[cacheKey] = glConvertMatrix;?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Removes heavy math, unnecessary inits and switch statements from CM shader.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Ready. Requires hyprwm/hyprgraphics#14