binds: drag_threshold for click/drag isolation

[alaricljs]

This code was abandoned in #9658 and I'm picking it back up.

New features

Added binds:drag_threshold to yoink windows with mouse binds only after moving a few pixels
Added bindc / bindg (click / drag) flags for release binds that check if inside/outside drag_threshold on release

Threshold handling is slightly different whether there is a bindm on the same button or not:

If there is no bindm on the same button, any amount of movement that ends inside the threshold will trigger a click
If bindm exists and has been triggered, returning inside the threshold will not trigger a click (triggers drag)

These are mutually exclusive.

Simple example that adds more window handling to the same 2 buttons:

binds {
drag_threshold = 20
}

bindm = SUPER, mouse:272, movewindow
bindc = SUPER, mouse:272, togglefloating
bindm = SUPER, mouse:273, resizewindow
bindc = SUPER, mouse:273, fullscreen

Thoughts

The default threshold = 0 should work like current default behavior, i.e. windows are grabbed immediately on mousedown. With threshold > 0 yoinking happens later on mousemove.

This probably obsoletes #8143 and fixes #9631.

Is it ready for merging:

• It was nearly at the finish line. I removed the duplicate modifactions of layout: center floating window at cursor when picked up from fullscreen #9780
• Wiki PR Variables and Binds: Document input:drag_threshold and related bind f… hyprland-wiki#1023

[vaxerski]

ping me tomorrow pls

[alaricljs]

ping @vaxerski, a day late but I'm not at my desk much on weekends.

[vaxerski]

looks pretty ok to me. Needs a wiki mr

[alaricljs]

@vaxerski hyprwm/hyprland-wiki#1023

Feedback?

[vaxerski]

hm. Now that I look at it, wouldn't c and g be better as extensions to m?

bindmc bindmg

and error out if it's not m? Otherwise it's less intuitive

[Dregu]

I originally though about including the m too, but decided it would also be confusing, because m implies you can only use mouse binds, which is not true at all with c/g. I guess it's just about how you document it. In the end I did it this way simply because I thought the other way would've made the flag parsing code and documentation more complicated for me, and obviously I'm lazy.

Anyway glad you picked this up again.

[alaricljs]

As Dregu points out, the drag_threshold is measured for c, g, and m bind flags. c and g are only applicable to non-m binds since drag_threshold is fundamentally part of bindm. Are you looking to have a bindm option to toggle off drag_threshold?

[alaricljs]

I've pushed a wiki change with hopefully a clearer explanation/description.

[vaxerski]

yes, that's clearer. Thanks

[nnyyxxxx]

ugh. this reverts a few commits

[nnyyxxxx]

It was nearly at the finish line. I removed the duplicate modifactions of layout: center floating window at cursor when picked up from fullscreen #9780

that's wrong since you are moving the same affected codepaths around, #9658 (comment) vaxry was wrong here as well #9780 should have been superseded by #9658

[Dregu]

Oh no exactly the thing I said would happen happened /s