input: add warp_on_toggle_special #9945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Currently the
cursor:warp_on_change_workspace
option does only apply to changing normal workspaces and not to toggling special ones. This has been bothering me for quite some time because it seems unintuitive and I would often accidentally switch windows on my special workspace because of it.This PR also warps the cursor on special workspace toggles when
cursor:warp_on_change_workspace
is enabled. I think this should be the expected behavior because to me opening a special workspace is also a "change of workspace".Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I can imagine that some users might prefer the old behaviour (i.e. only warping cursor on normal workspace change). So maybe it would be best to gate this behind an additional config var? I also thought about using a different number for
warp_on_change_workspace
to enable it for specials too, but that wouldn't really make too much sense because2
is already used for forcing.Is it ready for merging, or does it need work?
Yes