Fix stack overflow on parsing deeply nested expressions #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickpeterse
added
feature
Added a maximum expression depth of 64 to the parser and a more helpful error message if it's exceeded. This fixes inko-lang#788. Changelog: fixed
yorickpeterse
force-pushed
the
issue-788
branch
from
87b0816 to
e47c00a
Compare
|
I added a test and made some small formatting changes, but it seems I pushed them to the PR branch the wrong way such that it got closed. As such, I just merged it into e47c00a and pushed locally. @Keithcat1 Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a maximum expression depth of 64 to the parser and a more helpful error message if it's exceeded
This fixes #788
Changelog: fixed