-
Notifications
You must be signed in to change notification settings - Fork 53
Update PDF extraction and OCR options for hybrid chunking #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
d97fb71
to
6790918
Compare
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
8de7679
to
51fb86d
Compare
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
935c050
to
45ea8f4
Compare
45ea8f4
to
bdd771a
Compare
bdd771a
to
87e4278
Compare
87e4278
to
16427d5
Compare
9915bed
to
71a33b3
Compare
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
71a33b3
to
88de4c6
Compare
…p in test.yml Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
bbrowning
reviewed
Apr 3, 2025
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
098446e
to
9e627a5
Compare
eshwarprasadS
approved these changes
Apr 8, 2025
bbrowning
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been through a lot of iterations and looks good overall. I appreciate all the extra tests added and the removal of large portions of code that we no longer have to maintain around docling json parsing 🎉
khaledsulayman
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
Affects CI/CD configuration
dependencies
Pull requests that update a dependency file
testing
Relates to testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #503 , #436