feat(ui): add button to go to model manager next to all model combobox #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/feat/ui/go-to-mm-buttons-everywhere
branch
from
15b2cf7 to
09021df
Compare
…ionality If provided, `<NavigateToModelManagerButton />` will render, even if `disabledTabs` includes "models". If provided, `<NavigateToModelManagerButton />` will run the callback instead of switching tabs within the studio. The button's tooltip is now just "Manage Models" and its icon is the same as the model manager tab's icon ([CUBE!](https://www.youtube.com/watch?v=4aGDCE6Nrz0)).
…undefined` This fixes an issue where the refiner combobox doesn't clear itself visually when clicking the little X icon to clear the selection.
…ent ui for all model fields
psychedelicious
force-pushed
the
psyche/feat/ui/go-to-mm-buttons-everywhere
branch
from
3b33984 to
60d8dfd
Compare
This resolves a bug where SVG elements were ignored when checking when cursor is over a resize handle
|
This PR has turned into a new-combobox-component PR. The most important one is the model picker, which is fully customized and functional now: Screen.Recording.2025-04-17.at.10.27.50.pm.movTODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onClickGoToModelManagerprop to override what the button does. If this is provided, the button will render, even if the model manager is set as a disabled tab (the tab will not render).Well, it turns out that is a crapload of added buttons. Too many? Maybe. Demo:
Screen.Recording.2025-04-09.at.4.33.00.pm.mov
Related Issues / Discussions
Offline discussion
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)