Feature/Download #13
Merged
Feature/Download #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
changed the base branch from
develop
to
feature/qr-generation-setup
martinyde
reviewed
Feb 10, 2025
There was a problem hiding this comment.
I added code analysis to github actions and fixed a few of the errors found, but still a few remain. Run task composer -- code-analysis or task check-code locally to output them.
I consulted @cableman and I don't think we should move away from storing uuid as binary. I believe it's best practice. If there are implications with this approach we should discuss further.
martinyde
requested changes
Feb 10, 2025
…configuration options.
…figuration, and default sort implementation.
…pdatedAt timestamps.
jeppekroghitk
force-pushed
the
feature/qr-download
branch
from
e61a7bb to
8542d39
Compare
martinyde
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added single and batch download fuctionality.
Batch download functionality page with live updating preview of qr codes.
Downloading multiple qr codes as zip.
Screenshot of the result
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.