Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Extract inline assets #18

Merged
merged 14 commits into from
Feb 24, 2025
Merged

Conversation

jeppekroghitk
Copy link
Contributor

@jeppekroghitk jeppekroghitk commented Feb 21, 2025

Link to ticket

N/A

Description

Extracted inline assets - serve using webpack.
Extended base twig to include new assets.
Improved qr batch download previewer to serve previews for all qrs to be downloaded.

Screenshot of the result

Screenshot 2025-02-21 at 14 44 48

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@jeppekroghitk jeppekroghitk force-pushed the feature/extract-inline-assets branch from 1715b65 to 496993f Compare February 21, 2025 13:43
@turegjorup turegjorup merged commit ec98703 into develop Feb 24, 2025
10 checks passed
@turegjorup turegjorup deleted the feature/extract-inline-assets branch February 24, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants