Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make types non distributive #63

Merged
merged 1 commit into from
Sep 26, 2024
Merged

make types non distributive #63

merged 1 commit into from
Sep 26, 2024

Conversation

janglad
Copy link
Owner

@janglad janglad commented Sep 26, 2024

Previously a type coming out of the hook could end up as Result<"good", never> | Result<never, "bad"> instead of Result<"good", "bad">. This caused some weird issues when trying to discriminate by using isOk() and isErr()

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
safe-fn ❌ Failed (Inspect) Sep 26, 2024 8:57pm

@janglad janglad merged commit 3db9ef6 into main Sep 26, 2024
2 of 3 checks passed
@janglad janglad deleted the bug/distributive-action-types branch September 26, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant