fix: retry bootstrap check on on controllers when there are errors #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, when concierge checks for a bootstrapped controller, if the command fails the check is considered a failure, and thus that the controller doesn't exist. In some cases, that is correct, and we can tell that from the error message. In other cases, the check fails because the controller fails to respond. This commit introduces a retry with backoff on that check.
This was referenced Feb 24, 2025
carlcsaposs-canonical
added a commit
to canonical/postgresql-test-app
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when concierge checks for a bootstrapped controller, if the command fails the check is considered a failure, and thus that the controller doesn't exist.
In some cases, that is correct, and we can tell that from the error message. In other cases, the check fails because the controller fails to respond.
This commit introduces a retry with backoff on that check.