skeleton for openapi implementation #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstonskj
reviewed
Feb 25, 2022
| MANIFEST_DIR, file_name | ||
| )); | ||
| let expected_file = PathBuf::from(format!( | ||
| "{}/tests/models/{}.openapi.jsoN", |
johnstonskj
reviewed
Feb 25, 2022
brendo-m
commented
Feb 26, 2022
Comment on lines
+79
to
+81
| let title = if traits.contains_key(title_trait_id) { | ||
| expect_string_trait_value(traits, title_trait_id) | ||
| } else { |
There was a problem hiding this comment.
not sure if this is the best way to go about extracting traits. I'd like to is_titled but HasTraits is not implemented for Service. Not sure how this all fits together just yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of what I'm sure will be many, many commits to implement the openapi crate. I'm opening this as a draft PR so I can develop it in the open and get early feedback (which I would very much appreciate!).
My overall plan is to build it TDD style implementing all the tests in https://github.com/awslabs/smithy/tree/main/smithy-openapi/src/test/resources/software/amazon/smithy/openapi/fromsmithy. I've added one of them and some plumbing to run the test. Next step will be to make this test passes.
I looked around briefly and didn't find any openapi crates I liked. They all have additional functionality beyond just struct definitions for the types. I'll probably provide a model implementation in this repo inspired by the others just to reduce a dependency.Actually, this looks promising.
I'm excited to contribute!