Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show test time with [mix amrita --trace] as similar way as ExUnit. #80

Merged
merged 1 commit into from
Oct 20, 2013

Conversation

parroty
Copy link
Contributor

@parroty parroty commented Oct 20, 2013

Hi. I'm interested in the issue #49 (Progress formatter captures and prints the slowest 10 tests), and I was playing around it. As for the first step, how do you think about having [mix amrita --trace] as similar way as [mix test --trace]?
It's updated for success and failure tasks.

% mix amrita --trace
test/integration/t_scoping.exs:5: unused import Support
test/integration/t_scoping.exs:12: this clause cannot match because a previous clause at line 7 always matches

Elixir.Integration.AsyncFacts
  testing async (0.00ms)

Elixir.CheckerFacts
  converting predicates into strings 
    arity 1 renders just predicate (0.00ms)
    atom argument is rendered (0.01ms)
    nil argument is rendered (0.00ms)
    string argument is rendered (3.2ms)
  converts negated predicates into strings 
....

@josephwilk
Copy link
Owner

Looks good, thanks! Really nice to be able to use this on my projects.

My only thought is that --trace might have a little extra baggage from ExUnit. It also switches on a more verbose mode about the test names (a little like Amrita's documentation formatter). I'm not sure of a better name and am happy enough to live with --trace for now.

josephwilk added a commit that referenced this pull request Oct 20, 2013
Show test time with [mix amrita --trace] as similar way as ExUnit.
@josephwilk josephwilk merged commit bdb282a into josephwilk:master Oct 20, 2013
@parroty
Copy link
Contributor Author

parroty commented Oct 20, 2013

Thank you for the merge & comments!

@parroty parroty deleted the timer branch October 20, 2013 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants