Move test dependencies to dev-dependencies #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should even go further and remove all but:
And the right syntax is the [tool.poetry.group.dev.dependencies] notation. [tool.poetry.dev.dependencies] can be removed and does not work any longer with a recent version of poetry. Please change that and i will merge it. |
Move all but the obligatory dependencies to the `dev` group. This ensures that these packages (such as `pytest-cov`) are not incorrectly installed into the production environment, e.g. when issuing `pip install git+https://github.com/kakolukia/pypugjs`.
|
Updated. Thanks! |
|
Release i out there and pip install --no-binary :all: 'pypugjs' is installing it. |
|
Thanks a lot! It looks good on my end too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move dependencies that are used only when running tests / doing development to
dev-dependencies. Otherwise, Poetry creates unconditional dependency on these packages (such aspytest-cov), and they would be incorrectly installed into the production environment, e.g. when issuingpip install git+https://github.com/kakolukia/pypugjs.