Skip to content

srload: Cleanup when running outside buildtree #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

srload: Cleanup when running outside buildtree #1018

merged 1 commit into from
Apr 14, 2025

Conversation

mattiaswal
Copy link
Contributor

The original syntax did not work and the initial intention, that root is always required is also false.

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal
srload: Cleanup when running outside buildtree
028ab7c 
The original syntax did not work and the initial intention,
that root is always required is also false.
@mattiaswal mattiaswal requested a review from troglobit April 11, 2025 18:35
troglobit
troglobit approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattiaswal mattiaswal merged commit a4def13 into main Apr 14, 2025
6 checks passed
@mattiaswal mattiaswal deleted the clean-srload branch April 14, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattiaswal @troglobit