Upgrade to go 1.23

.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.19.x, 1.20.x, 1.21.x]
+        go-version: [1.21.x, 1.22.x, 1.23.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     steps:
@@ -21,6 +21,6 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.55
+          version: v1.63
       - run: go vet ./...
       - run: go test -v -race ./...

.golangci.yml

@@ -9,3 +9,5 @@ linters:
     - gofmt
     - gocritic
     - unconvert
+    - revive
+    - govet

example_request_test.go

@@ -37,7 +37,7 @@ func makeRequests(ctx context.Context, requests []Request, window int) (results
 
 	pipeliner := pipeliner.NewPipeliner(window)
 
-	worker := func(ctx context.Context, i int) error {
+	worker := func(_ context.Context, i int) error {
 		res, err := requests[i].Do()
 		resultsLock.Lock()
 		results[i] = res

go.mod

@@ -3,8 +3,8 @@ module github.com/keybase/pipeliner
 go 1.19
 
 require (
-	github.com/stretchr/testify v1.8.4
-	golang.org/x/net v0.19.0
+	github.com/stretchr/testify v1.10.0
+	golang.org/x/net v0.34.0
 )
 
 require (

go.sum

@@ -2,10 +2,10 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
-github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
-golang.org/x/net v0.19.0 h1:zTwKpTd2XuCqf8huc7Fo2iSy+4RHPd10s4KzeTnVr1c=
-golang.org/x/net v0.19.0/go.mod h1:CfAk/cbD4CthTvqiEl8NpboMuiuOYsAr/7NOjZJtv1U=
+github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
+github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
+golang.org/x/net v0.34.0 h1:Mb7Mrk043xzHgnRM88suvJFwzVrRfHEHJEl5/71CKw0=
+golang.org/x/net v0.34.0/go.mod h1:di0qlW3YNM5oh6GqDGQr92MyTozJPmybPK4Ev/Gm31k=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

pipeliner.go

@@ -7,7 +7,7 @@ import (
 )
 
 // Pipeliner coordinates a flow of parallel requests, rate-limiting so that
-// only a fixed number are oustanding at any one given time.
+// only a fixed number are outstanding at any one given time.
 type Pipeliner struct {
 	sync.RWMutex
 	window int
@@ -46,7 +46,7 @@ func (p *Pipeliner) launchOne() {
 // another request. It returns an error if any prior request failed,
 // instructing the caller to stop firing off new requests. The error
 // originates either from CompleteOne(), or from a context-based
-// cancelation
+// cancellation
 func (p *Pipeliner) WaitForRoom(ctx context.Context) error {
 	for {
 		p.checkContextDone(ctx)

pipeliner_test.go

@@ -3,11 +3,12 @@ package pipeliner
 import (
 	"context"
 	"errors"
-	"github.com/stretchr/testify/require"
 	"math/rand"
 	"sync"
 	"testing"
 	"time"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestPipeliner(t *testing.T) {
@@ -58,7 +59,7 @@ func testPipeliner(doError bool, doCancel bool) ([]int, error) {
 		ctx, cancelFunc = context.WithCancel(ctx)
 	}
 
-	f := func(ctx context.Context, i int) error {
+	f := func(_ context.Context, i int) error {
 		if doError && i == 20 {
 			return errors.New("errored out")
 		}