Skip to content

Feature/truncatedscore survival #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 4, 2025
Merged

Conversation

kkholst
Copy link
Owner

@kkholst kkholst commented Mar 19, 2025

estimate_truncatedscore by default now estimates survival probability instead of cumulative incidence.
truncatedscore data added to the package, and some documentation.

@kkholst kkholst requested a review from benesom March 19, 2025 17:39
@kkholst kkholst changed the base branch from main to dev March 19, 2025 17:39
@@ -131,35 +131,35 @@ test_intersectsignedwald <- function(thetahat1,
#' @param cens.code (integer) Censoring code.
#' @param naive (logical) If TRUE, the unadjusted estimates ignoring baseline
#' covariates is returned as the attribute 'naive'.
#' @param control (list) optimization routine parameters.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can add more information about this parameter. The default option is to use control$riskmethod <- "ate_riskRegression". What other risk methods are available?

Copy link
Collaborator

@benesom benesom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side because I'm unfamiliar with the methods you're implementing.

Are you planning to add some unit tests in the future?

@kkholst kkholst merged commit b315645 into dev Apr 4, 2025
2 of 3 checks passed
@kkholst kkholst deleted the feature/truncatedscore-survival branch April 4, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants