Skip to content

Add eks service account mutator webhook #4063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Helen300
Copy link

@Helen300 Helen300 commented Mar 30, 2025

What this PR does / why we need it:

This PR adds a new repository to the KubeVirt org. This repo will be used to host the source code for the mutator webhook for injecting virtiofs containers into virt-launcher pods that have an EKS service account token associated with it. The virtiofs containers will be used to share the tokens as filesystem mounts to the VM so that any changes/refresh to the token will also propagate to the VM.

This will be an extension of KubeVirt and specifically handles the case in which kube service account tokens containing EKS annotations are mounted as volumes to a kubevirt VM.

Related to kubevirt/kubevirt#13738 and kubevirt/kubevirt#13311

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Signed-off-by: Helen <43377525+Helen300@users.noreply.github.com>
@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 30, 2025
@kubevirt-bot
Copy link
Contributor

Hi @Helen300. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot requested review from enp0s3 and xpivarc March 30, 2025 14:05
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Helen300 Helen300 marked this pull request as ready for review March 30, 2025 14:20
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2025
@kubevirt-bot kubevirt-bot requested a review from dhiller March 30, 2025 14:20
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Helen300

Thanks for creating this PR and your work on this so far.

Before adding a new repo, we generally like to introduce the new repo/project to the community on the mailing list and explain why this new repo is needed. This will help with getting wider community awareness and feedback.

Also I think you will need to find a couple of community members to volunteer to be maintainers for this repo as we will need to identify owners before we create the repo. Maybe you could include this request in the mailing list introduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants