Fix duplicate endpoint handling in HealthCheckedEndpointGroup
#6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `HealthCheckedEndpointGroup` uses a list instead of a set to gather all endpoints, allowing for potential duplicates. However, when checking endpoints before adding them from the old group, it iterates over all elements, leading to issues. A separate set is needed to handle this properly. Modifications: - Introduced an additional set to track endpoints when updating from the old group. Result: - Ensures efficient endpoint updates in `HealthCheckedEndpointGroup`.
jrhee17
approved these changes
Apr 3, 2025
ikhoon
approved these changes
Apr 7, 2025
ikhoon
pushed a commit
to ikhoon/armeria
that referenced
this pull request
Apr 8, 2025
…#6190) Motivation: `HealthCheckedEndpointGroup` uses a list instead of a set to gather all endpoints, allowing for potential duplicates. However, when checking endpoints before adding them from the old group, it iterates over all elements, leading to issues. A separate set is needed to handle this properly. Modifications: - Introduced an additional set to track endpoints when updating from the old group. Result: - Ensures efficient endpoint updates in `HealthCheckedEndpointGroup`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HealthCheckedEndpointGroupuses a list instead of a set to gather all endpoints, allowing for potential duplicates. However, when checking endpoints before adding them from the old group, it iterates over all elements, leading to issues. A separate set is needed to handle this properly.Modifications:
Result:
HealthCheckedEndpointGroup.