Skip to content

upcoming: [DI-24470] - Rename resources to entities in labels, placeholders and messages in cloudpulse alerting #11977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Apr 7, 2025

Description 📝

Rename resources to entities in labels, placeholders and messages in cloudpulse alerting create, edit and details flow.

Changes 🔄

  1. Rename resources to entities in labels of cloudpulse alerting section
  2. Rename resources to entities in placeholders, errors, messages and warnings in cloudpulse alerting section

Target release date 🗓️

10th April 2025 in alpha

Preview 📷

Before After
Screenshot 2025-04-07 at 3 03 07 PM Screenshot 2025-04-07 at 3 03 19 PM
Screenshot 2025-04-07 at 3 03 40 PM Screenshot 2025-04-07 at 3 03 47 PM
Screenshot 2025-04-07 at 3 04 11 PM Screenshot 2025-04-07 at 3 03 58 PM
Screenshot 2025-04-07 at 3 04 23 PM Screenshot 2025-04-07 at 3 05 07 PM

How to test 🧪

  1. Login as mock, as some endpoints are not available.
  2. Navigate to monitor and to alerts section
  3. In the create alert, edit alerts and show details page, see the resources section, now it should be entities altogether.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@venkymano-akamai venkymano-akamai marked this pull request as ready for review April 7, 2025 10:34
@venkymano-akamai venkymano-akamai requested review from a team as code owners April 7, 2025 10:34
@venkymano-akamai venkymano-akamai requested review from dmcintyr-akamai, carrillo-erik and cpathipa and removed request for a team April 7, 2025 10:34
@venkymano-akamai
Copy link
Contributor Author

@cpathipa / @carrillo-erik / @dmcintyr-akamai , this should be good for another pass. Please take a look

Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update the "resources"/"resource" instances in the following files?

Also, should the "resources/resource" in the test case titles (e.g., in EditAlertLanding.test.tsx#L17C18, etc) be updated for consistency with what we are testing in the test cases?

@venkymano-akamai
Copy link
Contributor Author

venkymano-akamai commented Apr 9, 2025

@pmakode-akamai , I have updated the message in EditAlertResourceConfirmationDialog and EditAlertLanding.test.tsx

The FilterConfig is associated to dashboards and not related to alerts, so we will not be doing the changes there.
The ResourceMultiSelect is not used anywhere as of now, so don't need to do the changes there and possibly in future we will consider removing the entire component

Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, @venkymano-akamai - looks good!

✅ renamed resources to entities
✅ all tests pass

@pmakode-akamai pmakode-akamai added the Approved Multiple approvals and ready to merge! label Apr 9, 2025
…entities_linode

# Conflicts:
#	packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Resources/CloudPulseModifyAlertResources.test.tsx
@venkymano-akamai
Copy link
Contributor Author

venkymano-akamai commented Apr 9, 2025

@dmcintyr-akamai / @jdamore-linode , can we check the cypress changes here, there are only changes for renaming and no changes in logic

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 540 passing tests on test run #15 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing540 Passing4 Skipped110m 12s

@venkymano-akamai
Copy link
Contributor Author

Merging with enough approvals, jobs pass and cypress pass

@venkymano-akamai venkymano-akamai merged commit f87bc9d into linode:develop Apr 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Cloud Pulse - Alerting Cloud Pulse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants