refactor: [M3-9723] - Managed Tanstack routing #11994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-9723
branch
2 times, most recently
from
a5e3ca0 to
a9cf99d
Compare
abailly-akamai
commented
Apr 10, 2025
| }); | ||
|
|
||
| return groups; | ||
| }; |
There was a problem hiding this comment.
just moved that util but it is unchanged
| enabled, | ||
| refetchInterval: 20000, | ||
| }); | ||
|
|
There was a problem hiding this comment.
The queries added here were apparently never needed cause we were fetching ALL then filtering to get a single record. As with other routing refactors and our new standards, we now fetch an individual record when performing an action in a drawer, modal etc
abailly-akamai
requested review from
jdamore-linode,
mjac0bs and
carrillo-erik
and removed request for
a team
jdamore-linode
approved these changes
Apr 17, 2025
mjac0bs
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Thanks for the patience on this one and sorry it took me longer than I liked to get to. And as always, thanks for your work on this + your thoroughness in doing them.
Confirmed:
- Routes are routing as expected for create, edit, and delete actions
- Successful CRUD operations for SSH Access, Contacts, and Credentials
- Didn't test Monitor CRUD operations since we don't have support for that in the MSW, but did confirm the routes update as expected when interacting with the actions
- 🐛 Noted the
undefinedlabel in the header of the HistoryDrawer
- Sorting and filtering tables works for all tables
- Backwards and forwards browser navigation
- Visual parity with prod
Comment on lines
+22
to
+37
| <MaskableText isToggleable text={contact.name} /> | ||
| </TableCell> | ||
| <Hidden mdDown> | ||
| <TableCell> | ||
| <MaskableText text={contact.group ?? ''} isToggleable /> | ||
| <MaskableText isToggleable text={contact.group ?? ''} /> | ||
| </TableCell> | ||
| </Hidden> | ||
| <TableCell> | ||
| <MaskableText text={contact.email} isToggleable /> | ||
| <MaskableText isToggleable text={contact.email} /> | ||
| </TableCell> | ||
| <Hidden xsDown> | ||
| <TableCell> | ||
| <MaskableText text={contact.phone.primary ?? ''} isToggleable /> | ||
| <MaskableText isToggleable text={contact.phone.primary ?? ''} /> | ||
| </TableCell> | ||
| <TableCell> | ||
| <MaskableText text={contact.phone.secondary ?? ''} isToggleable /> | ||
| <MaskableText isToggleable text={contact.phone.secondary ?? ''} /> |
There was a problem hiding this comment.
Thanks for the clean up. 🧹
There was a problem hiding this comment.
Minor: some linter warnings in this file
carrillo-erik
approved these changes
Apr 17, 2025
Cloud Manager UI test results🎉 559 passing tests on test run #16 ↗︎
|
rodonnel-akamai
pushed a commit
to rodonnel-akamai/manager
that referenced
this pull request
Apr 23, 2025
* Initial commit: landing routing * monitors * remove barrel files * save progress * Wrap up monitors * SSH Access * Credentials * Wrapping up UI * fix units * e2e fixes * fix after rebase * fix remainin e2e failure * eslint fix * eslint fix * linting fixes * Added changeset: Managed Tanstack routing * feedback @mjac0bs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR migrates our routing tooling in the Managed feature to Tanstack router.
It also cleans up the code to adhere to our latest standards.
Changes 🔄
Preview 📷
There should not be any visual or functional regression with the feature. Only difference is the introduction of loading patterns in some edit/delete drawer/modals
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅