Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toml serialization! #6

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

abueide
Copy link

@abueide abueide commented Sep 18, 2024

Hello!

I started learning gleam a few days ago for a project I'm working on which also needs toml serialization, so I thought I'd give implementing the toml serializer in gleam a shot. This is still a WIP, not all the tests are implemented yet, but most of the functionality is working. It can take a Toml value and turn it into a string! Will finish out the tests, covering edge cases, and applying feedback and adding documentation in the next few days. Also will want to spend some time thinking about what the user-sided API will look like so they don't have to write ugly nested toml trees everywhere for their type converters if possible.

I'm definitely a gleam novice, so any advice to code quality is hugely appreciated.

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh neat! Thank you.

I've not reviewed the code yet, but it looks like you've some debug printing left in and the tests are currently failing. Would you mind sorting that out first?

@lpil lpil marked this pull request as draft September 20, 2024 14:15
@abueide
Copy link
Author

abueide commented Sep 20, 2024

Yup! am working on it a bit, i still have a lot more tests to write and want to add some way to configure some formatting options. also not super happy with the readability of some of the code, mainly was just opening draft pr on the first working version to see if anyone was able to suggest better ways to do things since i'm a gleam novice and might be misusing features or missing a feature that would make things cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants