vtech/prestige.cpp, snotec.xml: Add snotecut and 4 new software items #13524
Conversation
* Extended bank selection to support snotecut, as ROM size 0x200000 requires more entries to be fully addressable; * Added list of extra programs in currently dumped systems; * Sorted software items by name, and added missing fields for alt_title and serial; New working software items (snotec.xml) --- Nakayoshi Diary (1999) [TeamEurope, QUFB] Ochame na PetMate 2 [TeamEurope, QUFB] New partially working software items (snotec.xml) --- Nakayoshi PetMate [TeamEurope, QUFB] Primo Puel [TeamEurope, QUFB] New clones marked not working --- Super Note Club µ teen's time (Japan) [TeamEurope, QUFB]
| <software name="caudit"> | ||
| <description>Challenge Audition</description> | ||
| <year>1998</year> | ||
| <publisher>Bandai</publisher> | ||
| <info name="alt_title" value="チャレンジオーディション めざせアイドル"/> |
There was a problem hiding this comment.
Is there a reason you didn’t include the full title “Challenge Audition Mezase Idol” in the description?
| <software name="conan2"> | ||
| <description>Detective Conan 2</description> | ||
| <year>1996</year> | ||
| <publisher>Bandai</publisher> | ||
| <info name="alt_title" value="名探偵コナン エピソード2"/> |
There was a problem hiding this comment.
Same here, is there a reason not to use “Detective Conan Episode 2” in the description?
| <description>Detective Conan 3</description> | ||
| <year>1999</year> | ||
| <publisher>Bandai</publisher> | ||
| <info name="alt_title" value="名探偵コナン エピソード3"/> | ||
| <info name="serial" value="73394"/> |
There was a problem hiding this comment.
And here it also has “Episode” in the Japanese title.
| <software name="magicalf"> | ||
| <description>Magical Fortune</description> | ||
| <year>1996</year> | ||
| <publisher>Bandai</publisher> | ||
| <info name="alt_title" value="7つの占いで未来が見える! マジカルフューチャー"/> |
There was a problem hiding this comment.
The titles don’t seem to match up at all here (“Magical Fortune” vs “Magical Future” as well as whether to include “7-tsu no Uranai de Mirai ga Mieru!” in the title).
| <software name="tamago"> | ||
| <description>Tamagotchi</description> | ||
| <year>1997</year> | ||
| <publisher>Bandai</publisher> | ||
| <info name="alt_title" value="スーパーノートで発見!! たまごっち"/> | ||
| <info name="serial" value="58328"/> |
There was a problem hiding this comment.
You could use the double exclamation character “‼” in the Japanese title. Also, is “Super Note de Hakken” part of the title or not? It should be consistent.
| u32 EXTRA_PROGRAM_OFFSET; | ||
| u16 NUM_ROM_ENTRIES; | ||
| u16 ROM_BANK_MASK; |
There was a problem hiding this comment.
Please don’t use SCREAMING_SNAKE_CASE for things that are not actually constants/macros. Give them m_snake_case names.
| { } | ||
| { | ||
| EXTRA_PROGRAM_OFFSET = 0x40000; | ||
| NUM_ROM_ENTRIES = 64; | ||
| ROM_BANK_MASK = 0x3f; |
There was a problem hiding this comment.
Please be consistent using the initialiser list to initialise members.
| NUM_ROM_ENTRIES = 128; | ||
| ROM_BANK_MASK = 0x7f; |
There was a problem hiding this comment.
Can’t you work these out from the size of the program ROM region?
New working software items (snotec.xml)
Nakayoshi Diary (1999) [TeamEurope, QUFB]
Ochame na PetMate 2 [TeamEurope, QUFB]
New partially working software items (snotec.xml)
Nakayoshi PetMate [TeamEurope, QUFB]
Primo Puel [TeamEurope, QUFB]
New clones marked not working
Super Note Club µ teen's time (Japan) [TeamEurope, QUFB]