Include the required wkof.Menu module #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jitai 3.3.5 failed to load for me: WaniKani is as if Jitai was not installed at all, and the browser console has an error: ``` Uncaught (in promise) TypeError: Unhandled Promise Rejection: wkof.Menu is undefined ``` This change fixes it for me. It was a guess based on `Menu` only being mentioned in `supported_modules` in wkof’s code, and https://community.wanikani.com/t/wanikani-open-framework-developer-thread/22231/2 showing `wkof.include(…)`
|
Interesting! For me it even works without. Sounds to me like an incompatibility with wkof, maybe you are using an old version? My latest version of WKOF installed is v1.2.10. |
|
The error I see is also with wkof 1.2.10. If multiple scripts depend on wkof, do they share one global Either way, thanks for the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jitai 3.3.5 failed to load for me: WaniKani is as if Jitai was not installed at all, and the browser console has an error:
This change fixes it for me. It was a guess based on
Menuonly being mentioned insupported_modulesin wkof’s code, and https://community.wanikani.com/t/wanikani-open-framework-developer-thread/22231/2 showingwkof.include(…)