wayland/window closing: avoid a crash on gtk_widget_destroy #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not attempt to unref or destroy a child of a container *In GTK 3 at least, GtkContainers automatically destroy child widgets when destroyed
|
I have been chasing this crash for months and finally found it. Not a single crash since I installed caja with this change, and I looked for any memory leak behavior by repeatedly opening and closing windows while monitoring RAM consumption in mate-system-monitor. I'd like to have another set of eyes on this before merge if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*In GTK 3 at least, GtkContainers automatically destroy child widgets when destroyed
*Trying to do this with glib 2.82 or later causes sporadic crashes on closing a navigation window at least in wayland.