The cuda versions checking corrected #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCC versions supported by CUDA versions was not being checked correctly. This was fixed.
|
This was already addressed in 3dfb713. Moreover, any fixes pre 25.03 release need to be backported to AmberTools. If you have additional changes, please add them to #413 as that is how I am keeping track for backporting. Closing as duplicate. @agoetz: Please prioritize merging #413 to avoid future duplicate efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCC versions supported by CUDA versions was not being checked correctly.
This was fixed by enabling checking for CUDA versions 12.5, 12.6 and 12.8.
Note that CUDA version 12.7 is not released.
Fixes are localized to "quick-cmake/QUICKCudaConfig.cmake".