Skip to content

enhance: add optimize for like expr #41066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: add optimize for like expr #41066

wants to merge 1 commit into from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Apr 2, 2025

@sre-ci-robot sre-ci-robot requested review from bigsheeper and sunby April 2, 2025 11:15
@zhagnlu zhagnlu changed the title enhance: add optimize for like enhance: add optimize for like expr Apr 2, 2025
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 2, 2025
@dosubot dosubot bot added the kind/enhancement Issues or changes related to enhancement label Apr 2, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Apr 2, 2025
@sunby
Copy link
Contributor

sunby commented Apr 2, 2025

maybe should add some ut for InnerMatch of UnaryExpr

@sunby
Copy link
Contributor

sunby commented Apr 2, 2025

/lgtm

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 6fafe0c to f4cf452 Compare April 2, 2025 11:52
@sre-ci-robot sre-ci-robot removed the lgtm label Apr 2, 2025
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (6a9ecb7) to head (834b273).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41066       +/-   ##
===========================================
+ Coverage   72.62%   81.86%    +9.24%     
===========================================
  Files         312     1166      +854     
  Lines       29015   181159   +152144     
===========================================
+ Hits        21072   148310   +127238     
- Misses       7943    26703    +18760     
- Partials        0     6146     +6146
Components Coverage Δ
Client 79.59% <ø> (∅)
Core ∅ <ø> (∅)
Go 81.98% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/parser/planparserv2/pattern_match.go 100.00% <100.00%> (ø)

... and 1477 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from f4cf452 to 63d4d14 Compare April 2, 2025 12:56
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 63d4d14 to 9c731a1 Compare April 3, 2025 07:24
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch 2 times, most recently from 4d7290b to dc3c07b Compare April 7, 2025 12:01
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from dc3c07b to de6eaa6 Compare April 8, 2025 03:44
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from de6eaa6 to 52ce49b Compare April 8, 2025 06:41
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 52ce49b to 28901bd Compare April 9, 2025 11:22
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 9, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 2f424b9 to 6895712 Compare April 10, 2025 07:25
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/test sig/testing and removed size/L Denotes a PR that changes 100-499 lines. labels Apr 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 6895712 to 712045c Compare April 10, 2025 12:31
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 712045c to a615cb4 Compare April 10, 2025 15:37
@mergify mergify bot added the ci-passed label Apr 10, 2025
@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from a615cb4 to b446602 Compare April 11, 2025 03:57
@mergify mergify bot removed the ci-passed label Apr 11, 2025
@zhagnlu zhagnlu mentioned this pull request Apr 11, 2025
Merged
sre-ci-robot pushed a commit that referenced this pull request Apr 14, 2025
@zhagnlu
enhance: add optimize for like expr (#41222)
2498eb0 
pr: #41066  cherry-pick from master

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch 3 times, most recently from a09ca13 to ebd83b6 Compare April 15, 2025 11:30
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Apr 15, 2025
@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from ebd83b6 to 0e606d5 Compare April 15, 2025 11:33
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from 0e606d5 to bf1bc2f Compare April 15, 2025 12:09
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

liliu-z pushed a commit that referenced this pull request Apr 16, 2025
@zhagnlu @liliu-z
enhance: add optimize for like expr (#41222)
7d74f8b 
pr: #41066  cherry-pick from master

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Apr 17, 2025

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

enhance: add optimize for like
834b273 
Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the support_like_as_string_contains branch from bf1bc2f to 834b273 Compare April 17, 2025 07:59
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@sunby sunby Awaiting requested review from sunby

Assignees

@sunby sunby

Labels
area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhagnlu @sre-ci-robot @sunby