Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in retry while error handling #1392

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Mar 13, 2025

Verified with q

Expand for `q` Diff details to test with branch
diff --git a/sdk-releases/projects/minio-js b/sdk-releases/projects/minio-js
index 6136692..64456ef 100755
--- a/sdk-releases/projects/minio-js
+++ b/sdk-releases/projects/minio-js
@@ -50,7 +50,8 @@ function commit_release_info() {
 function make_build() {
        log "Building for release"
        assert npm install
-       log "Verifying build"
+       log "Verifying build 123"
+       log "Node version: $(node --version)  ${SERVER_ENDPOINT}"
        assert npm test
 }
 
@@ -80,13 +81,19 @@ function make_release() {
        assert dry_run git push --quiet
 }
 
+function get_branch() {
+       git fetch --all
+       git checkout fix-bug-error-rethrow
+}
+
 function main() {
-       url="https://github.com/minio/minio-js.git"
+       url="https://github.com/prakashsvmx/minio-js.git"
        if [ -n "$RELEASE" ]; then
                url="git@github.com:minio/minio-js.git"
        fi
 
        run_under "$SRC_DIR" setup_sources "$url"
+       run_under "$PROJ_GIT_DIR" get_branch
        run_under "$PROJ_GIT_DIR" commit_release_info
        run_under "$PROJ_GIT_DIR" make_build
        run_under "$PROJ_GIT_DIR" make_release


Cloning minio-js.git
Fetching origin
Branch 'fix-bug-error-rethrow' set up to track remote branch 'fix-bug-error-rethrow' from 'origin'.
Switched to a new branch 'fix-bug-error-rethrow'
Commit version 8.0.5
Building for release
Verifying build
Node version: v20.18.3  
Publishing release 8.0.5
Tagging release 8.0.5
Successfully released 8.0.5

Announce this release by adding release notes at
https://github.com/minio/minio-js/releases from 'trusted@minio.io'
account.  Release notes requires two sections 'highlights' and
'changelog'.

Highlights is a bulleted list of salient features in this
release and Changelog contains list of all commits since the last
release by;

git log --no-color --date=format:'%m/%d/%y' --pretty=format:'- %s (%ad) <%an>' 8.0.4..8.0.5

@prakashsvmx prakashsvmx self-assigned this Mar 13, 2025
@prakashsvmx prakashsvmx force-pushed the fix-bug-error-rethrow branch from 7fddc52 to aea7392 Compare March 13, 2025 07:58
@prakashsvmx prakashsvmx marked this pull request as ready for review March 13, 2025 08:27
@harshavardhana harshavardhana merged commit e5c92bf into minio:master Mar 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants