Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multipart-put benchmarking #383

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

d1tyo
Copy link

@d1tyo d1tyo commented Mar 25, 2025

Proposed solution (warp multipart-put) is aimed to benchmark uploading of multiple multipart objects concurrently. It periodically creates new multipart uploads and concurrently uploads parts.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't like warp multipart ?

@d1tyo
Copy link
Author

d1tyo commented Mar 25, 2025

You don't like warp multipart ?

warp multipart doesn't allow to benchmark multipart upload itself. It mostly benchmarks download and only uploads to a single multipart upload id.

Proposed solution is aimed to benchmark uploading of multiple multipart objects concurrently. It periodically creates new multipart uploads and concurrently uploads parts.

So proposed warp multipart-upload benchmarks a different scenario from warp multipart.

Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the name change. Rest should be trivial.

@d1tyo
Copy link
Author

d1tyo commented Mar 26, 2025

Just updated PR. I renamed both multipart_upload.go files to multipart_put.go as well.
Please take a look.

@d1tyo d1tyo requested a review from klauspost March 26, 2025 19:42
@d1tyo d1tyo changed the title Support multipart-upload benchmarking Support multipart-put benchmarking Mar 26, 2025
@d1tyo
Copy link
Author

d1tyo commented Mar 27, 2025

Updated it once again.

Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants