Tidy up methods for layout ties and bends #27592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
reviewed
Apr 10, 2025
| segList.push_back(&seg); | ||
| } | ||
| if (mb->isMeasure()) { | ||
| collectElementsToLayout(toMeasure(mb), elements, ctx); |
There was a problem hiding this comment.
Collecting all elements in a system when we know we only want the system, measures, and chords seems a waste of time on the surface. I doubt the performace/space improvements gained with only collecting what we need here would amount to much. Maybe something to bear in mind when you want to squeeze some more performance out of system layout!
miiizen
approved these changes
Apr 10, 2025
github-project-automation
bot
moved this from In Progress
to Done
in MuseScore Studio 4.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #27574