-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix Swing and Straight markings format #27188 #27600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The VTests failed; this should be fixed after a rebase, to integrate the latest changes from the master branch. |
Swing and Straight markings werent formatted correctly in the Tempo and Masters palette like the rest of the elements in the section. This occured because real Tempo texts automatically take the format because of the textStyleType, but since Swing and Straight elements are simple SystemTexts I add to call initTextStyleType so it could load the corresponding text style values. Also removed the call of the function setTextStyleType,since it is already called in initTextStyleType.
475f281
to
afae820
Compare
Thank you, I'll submit these changes! |
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Is this PR going to solve #26271, too? |
No, this is only about the text weight of those two particular cells. |
Thank you so much for approving my pr! |
Shoudln't that go to 4.5.2 too? |
It could. @cheilagoncalves perhaps that's nice, because then your work will soon be visible to the world. We can port the PR to the 4.5.2 branch for you, but maybe you would like to do it yourself:
|
Done, see #27697 |
Called the function initTextStyleType to load the corresponding text style values.
Resolves: #27188
The Swing and Straight markings weren't formatted correctly in the Tempo and Masters palette like the rest of the elements in the section. This occurred because real Tempo texts automatically take the format because of the textStyleType, but since Swing and Straight
elements are simple SystemTexts I add to call the function initTextStyleType so it could load the corresponding text style values.