Fix crash on clear & undo #27630
Merged
Fix crash on clear & undo #27630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Apr 10, 2025
|
Tested #27618 on Win10, Mac13.7.2, LinuxUbuntu24.04.2 LTS - FIXED |
mike-spa
approved these changes
Apr 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #27618
This was caused by starting and ending an undo command where it wasn't necessary (as one would always be in progress). Ending the command meant that the other changes (removing the note in this case) weren't added to the undo stack.
The PR also fixes another crash caused by following the reproduction steps in the issue then repeating steps 2 & 3:
2. Add C to 2nd measure
3. Add tie to C note in 1st measure
This was caused by another dangling pointer.