Plugin modal: tell user to install MSVC redistributable if needed #1795
Conversation
emlys
changed the title
There was a problem hiding this comment.
Thanks @emlys ! This worked great for me in a bare bones Windows VM. I had one suggestion about add a /norestart flag to the exe install call.
Otherwise the only thing that jumps out is that when we finish the 3rd party installer the user is left at the InVEST main page. Would it be possible / reasonable to open the manage plugin window on completion of the MSVCpp install?
| } | ||
| logger.info('Launching MSVC installer'); | ||
| const exePath = upath.join(tmpDir, exeName); | ||
| execFile(exePath); |
There was a problem hiding this comment.
Is it possible to add options to the install using this? I think it'd be nice to add the /norestart option. When testing with this option via the command line, it did as I expected and did not prompt to restart the computer. Without a restart it appears that DLL is found.
| <a href="https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist"> | ||
| {t('Microsoft Visual C++ Redistributable.')} | ||
| </a> | ||
| {t('You must download and install the redistributable before continuing.')} |
There was a problem hiding this comment.
I think we need a space before the sentence starting with You must download starts.
| @@ -187,6 +187,7 @@ describe('createWindow', () => { | |||
| ipcMainChannels.CHECK_FILE_PERMISSIONS, | |||
| ipcMainChannels.GET_SETTING, | |||
| ipcMainChannels.GET_N_CPUS, | |||
| ipcMainChannels.HAS_MSVC, | |||
There was a problem hiding this comment.
Looks like we need the DOWNLOAD_MSVC addition too.
Description
Fixes #1794
When a user opens the "Manage plugins" modal, check for the existence of the DLL that micromamba needs. If not found at the expected path, display a message and point the user to download and install the MSVC redistributable, which installs the DLL.
Checklist