Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP!!! FEATURE: Augment nodes in guestframe with html comments instead of data attributes #3941

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Apr 7, 2025

Relates: #3231

What I did

How I did it

Instead of a wrapping Dom element or augmenting a nodes markup, the backend creates 2 encapsulating html comments that contain all necessary data and allow interactions with nodes without markup manipulations.

This also needs an adjustment in Neos.Neos, as the wrapping class is still there.

  • Wrap content with comments instead of augmenting with data attributes
  • Load node addresses from comments
  • Make nodes selectable from content tree and in guest frame
  • Make nodes without markup work (no highlighting though)
  • Nodes are fully inline editable
  • OOB rendering reload
  • OOB move/copy (50%, still buggy)
  • Insert new node (untested)
  • Implement node highlighting from host frame like the buttoner
  • Make sure nodes with multiple Dom nodes without a single wrapping Dom element work correctly
  • Check if property augmenter can also be switched to comments (can be also a separate PR)
  • Move augmentation logic from Neos.Neos to Neos.Ui
  • Check if insertion anchor can be a comment (can also be a separate PR)

How to verify it

All manipulations of nodes in the guest frame and access from the host frame still work + e2e tests.

@github-actions github-actions bot added the 9.0 label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant