Skip to content

[WIP] option for store dir relative to the target dir #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunshowers
Copy link
Member

Still to figure out:

  • Write tests for parsing configuration.
  • Write tests which set configuration and ensure that output gets written to the right spot.
  • How should remapped archive directories be handled? Archive target directories are typically temporary directories which will be deleted at the end of the run. Using that as the store directory seems wrong. In that case, we may wish to use another location instead.

Still to figure out:

- [ ] Write tests for parsing configuration.
- [ ] Write tests which set configuration and ensure that output gets written to the right spot.
- [ ] How should remapped archive directories be handled? Archive target directories are typically temporary directories which will be deleted at the end of the run. Using that as the store directory seems wrong. In that case, we may wish to use another location instead.
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 67.23164% with 58 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (ccffb23) to head (8ec7575).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nextest-runner/src/config/store.rs 29.26% 29 Missing ⚠️
nextest-runner/src/reporter/aggregator/junit.rs 0.00% 16 Missing ⚠️
nextest-runner/src/config/config_impl.rs 45.45% 6 Missing ⚠️
cargo-nextest/src/errors.rs 0.00% 3 Missing ⚠️
nextest-runner/src/config/junit.rs 33.33% 2 Missing ⚠️
nextest-runner/src/reporter/aggregator/imp.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
- Coverage   80.35%   80.26%   -0.09%     
==========================================
  Files         104      105       +1     
  Lines       24597    24679      +82     
==========================================
+ Hits        19765    19809      +44     
- Misses       4832     4870      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

trunk-io bot commented Feb 16, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant