Json schema improvements #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also checked the schema_input.json and I didn't find anything that needed to be altered |
charles-plessy
requested changes
Mar 27, 2025
| @@ -17,13 +17,13 @@ | |||
| "format": "file-path", | |||
| "exists": true, | |||
| "schema": "assets/schema_input.json", | |||
| "mimetype": "text/csv", | |||
| "pattern": "^\\S+\\.csv$", | |||
| "pattern": "^\\S+\\.(csv|tsv|json|yaml|yml)$", | |||
There was a problem hiding this comment.
I think that we should stay restricted on .csv suffix as long as we only support the text/csv format.
| @@ -152,22 +153,22 @@ | |||
| }, | |||
| "skip_dotplot_o2m": { | |||
| "type": "boolean", | |||
| "description": "Do not generate the one-to-many alignment dot-plot.", | |||
| "description": "This option tells the pipeline to not generate the one-to-many alignment dot-plot.", | |||
There was a problem hiding this comment.
I would prefer to keep the description short. Other descriptions do not start with "This option tells the pipeline to". Can you leave that change out or suggest something more specific and concise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).