Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): pull less RxJS symbols #2309

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Mar 10, 2025

In this commit, we reduce the number of imported symbols from RxJS by removing the pairwise()
operator (since users consuming the NGXS library may not use it) and replacing RxJS of()
with a custom function that instantly returns an observable.

In this commit, we reduce the number of imported symbols from RxJS by removing the `pairwise()`
operator (since users consuming the NGXS library may not use it) and replacing RxJS `of()`
with a custom function that instantly returns an observable.
Copy link

nx-cloud bot commented Mar 10, 2025

View your CI Pipeline Execution ↗ for commit a3f02fd.

Command Status Duration Result
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx run-many --target=test --all --configuration... ✅ Succeeded 2s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-10 09:23:52 UTC

Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2309

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2309

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2309

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2309

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2309

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2309

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2309

commit: a3f02fd

Copy link

codeclimate bot commented Mar 10, 2025

Code Climate has analyzed commit d4b8da5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@arturovt arturovt force-pushed the refactor/pull-less-rxjs branch from d4b8da5 to a3f02fd Compare March 10, 2025 09:20
@arturovt arturovt marked this pull request as ready for review March 10, 2025 09:20
@arturovt arturovt merged commit 86e5d99 into master Mar 10, 2025
4 of 5 checks passed
@arturovt arturovt deleted the refactor/pull-less-rxjs branch March 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant