Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat qualified dot expr types same as idents #24687

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from
Draft

treat qualified dot expr types same as idents #24687

wants to merge 3 commits into from

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Feb 12, 2025

fixes #18095

Counting on the fact that the codebase should handle the tyFromExpr special cases here in semTypeExpr, could still break something. No idea what the code for nkIdent etc used here does differently than the code for nkSym.

@metagn metagn marked this pull request as ready for review February 12, 2025 15:53
@metagn metagn changed the title test treating qualified dot expr types same as idents treat qualified dot expr types same as idents Feb 12, 2025
@metagn metagn marked this pull request as draft February 15, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using sum types with module specifiers typechecks inconsistently
1 participant
@metagn