feat: add additional Get and Update methods #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this also renames TokenPolicy.Get to TokenPolicy.GetAll. This is a breaking change, but trivial to fix and then consistently named.
ldez
changed the title
|
Hi, I restored the previous lib API:
Like that, there are no breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, first of all thanks for maintaining this repo :)
there were some methods and fields missing which I need for terraform-provider-desec, so I added them in this PR.
Note in one case I renamed a
Getmethod toGetAll, implementing aGetthat is consistent with the other API. The original name was arguably incorrect, and while this is a breaking change it's trivial to fix and I imagine we're not being overly strict on versioning for this repo? If you have an alternative suggestion I'm happy to update.